[IA-4935] Generate azure prod vm password randomly
Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]
Summary of changes
What
- Replaces the Azure VM password with a randomly generated one in prod
Why
- Sharing a single password was a high security risk that needs to be mitigated
Testing these changes
What to test
I will test on my BEE, switching the logic to check for the random password there, but when it comes to testing if it works in prod... Well I am not quite sure how I can mock that 😅
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.69%. Comparing base (
2a1e544) to head (ccffe8b).
Additional details and impacted files
@@ Coverage Diff @@
## develop #4526 +/- ##
===========================================
+ Coverage 73.65% 73.69% +0.03%
===========================================
Files 158 159 +1
Lines 14699 14717 +18
Branches 1160 1184 +24
===========================================
+ Hits 10827 10845 +18
Misses 3872 3872
| Files | Coverage Δ | |
|---|---|---|
| ...titute/dsde/workbench/leonardo/config/Config.scala | 97.74% <100.00%> (+<0.01%) |
:arrow_up: |
| ...e/workbench/leonardo/util/AzurePubsubHandler.scala | 83.39% <100.00%> (+0.02%) |
:arrow_up: |
| ...ench/leonardo/util/AzurePubsubHandlerAlgebra.scala | 100.00% <100.00%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2a1e544...ccffe8b. Read the comment docs.
Going to force merge, this is an Azure change that has nothing to do with the GKE app creation failure that is a known flake