dasharo-issues icon indicating copy to clipboard operation
dasharo-issues copied to clipboard

User friendly firmware update v1

Open macpijan opened this issue 1 year ago • 10 comments

The problem you're addressing (if any)

Existing firware update procedure is too complex for regular end user.

Describe the solution you'd like

Dasharo firmware update option could be added in the top-level menu of DTS. We already have such option under number 5, but it was visible only when SE credentials were loaded.

Specific plan for this issue to achieve some better experience in this V1 version of the user friendly firmware update:

  • [x] Minimum code reorganization of DTS scripts (such as moving common functions or avariables into one file). More code reorgzniation may happen later. Here we want to focus on adding update entry, whout breaking other entries at the same time. (https://github.com/Dasharo/meta-dts/pull/29)
  • [x] Add basic (i.e. reuse the existing scripts infrastrcture as much as possible) Dasharo fw update option based on the existing code (https://github.com/Dasharo/meta-dts/pull/29)
  • [x] Improve general user experience on moving through the update flow (get rid of unnecessary logs from tools, be more descriptive about what is going on) (https://github.com/Dasharo/meta-dts/pull/29/commits/4e11dcc1e301a0f9331b624c81b8e9a9627534bf)
  • [x] Add support for NovaCustom ADL machines to DTS (currently, only TGL machines are supported)
  • [x] Add documentation on the new update option
  • [x] Test basic fw update on NV4X TGL (1.3.0 to 1.4.0 transition)
  • [x] Test basic fw update on NS5X TGL (1.3.0 to 1.4.0 transition)
  • [ ] Test basic fw update on NV4X ADL (1.4.0 to 1.5.0 transition)
  • [x] Test basic fw update on MSI Z690 DDR4 (1.1.0 to 1.1.1 transition)
  • [x] Test basic fw update on MSI Z690 DDR5 (1.1.0 to 1.1.1 transition)
  • [x] Test whether the existing functionality is not broken (SE keys management, initial deployment of supported platforms) ?

Where is the value to a user, and who might that user be?

End users stop bricking their hardware during update process. Lower entry for Dasharo users to kepp FW up to date.

Describe alternatives you've considered

fwupd integration in major Linux distrbutions could be a long-term goal

Additional context

macpijan avatar Mar 01 '23 11:03 macpijan

@macpijan plan sounds good, key point is automated validation of DTS features, without that we will not be able to refactor things in future. Focus of validation should be on delivered effects (initial deployment, update) not on user interface and messages since UI can change in future.

pietrushnic avatar Mar 01 '23 14:03 pietrushnic

Add documentation on the new update option Can be ticked off after merging https://github.com/Dasharo/docs/pull/493

@Pokisiekk did we test NS5X TGL?

TomaszAIR avatar Mar 02 '23 09:03 TomaszAIR

Add documentation on the new update option Can be ticked off after merging Dasharo/docs#493

Merged and ticked.

miczyg1 avatar Mar 02 '23 12:03 miczyg1

@macpijan what is needed to close this issue?

pietrushnic avatar Dec 07 '23 12:12 pietrushnic

@macpijan ping

pietrushnic avatar Jan 15 '24 23:01 pietrushnic

@macpijan Now that Firmware Update Mode has been integrated, I think the issue should be closed.

wessel-novacustom avatar Apr 15 '24 15:04 wessel-novacustom

Test basic fw update on NV4X ADL (1.4.0 to 1.5.0 transition) is still unchecked. not sure we can close this without proper explanation, why this single case has not been verified/checked

miczyg1 avatar Apr 16 '24 08:04 miczyg1

Test basic fw update on NV4X ADL (1.4.0 to 1.5.0 transition) is still unchecked. not sure we can close this without proper explanation, why this single case has not been verified/checked

@miczyg1 Good one. But shouldn't it be 1.4.0 to 1.7.2? I don't think 1.4.0 to 1.5.0 makes sense. Why would someone upgrade to a version that is not the latest?

wessel-novacustom avatar Apr 16 '24 08:04 wessel-novacustom

:shrug:

miczyg1 avatar Apr 16 '24 12:04 miczyg1

@macpijan What do you think?

wessel-novacustom avatar Apr 16 '24 12:04 wessel-novacustom