Flashing binary modified with smmstore tool results in being unable to change those options

[m-iwanicki]

Component

Dasharo firmware, Dasharo Tools Suite

Device

Hardkernel Odroid H4

Dasharo version

v0.9.1

Dasharo Tools Suite version

v2.7.1

Test case ID

No response

Brief summary

Flashing smmstore modified binary results in being unable change BIOS configuration

How reproducible

100%

How to reproduce

1. Flash v0.9.1

2. Modify the same binary with smmstore tool and flash it

   smmstoretool hardkernel_odroid_h4_v0.9.1.rom set -g f0a30bc7-af08-4556-99c4001009c93a44 -n SecureBootEnabled -t bool -v true
   smmstoretool hardkernel_odroid_h4_v0.9.1.rom set -g dasharo -n LockBios -t uint8 -v 1
   smmstoretool hardkernel_odroid_h4_v0.9.1.rom set -g dasharo -n SmmBwp -t uint8 -v 1
   flashrom -p internal --ifd -i bios -w hardkernel_odroid_h4_v0.9.1.rom
   

3. Reboot and try to change modified Dasharo System Features

Expected behavior

Can disable e.g. BIOS lock

Actual behavior

Submit Fail For Form

Screenshots

Additional context

• smmstore tool in DTS was built from this commit https://github.com/coreboot/coreboot/commit/602653abed391ae1b1445ad86d0f05b8b5b678cb
• Secure boot state can be changed, but other options in Dasharo System Features also don't work if they were modified by smmstore tool e.g. Network Boot

Solutions you've tried

No response

[mkopec]

Should have been fixed with https://github.com/Dasharo/edk2/pull/276