Dasharo
DTS: Entering empty password results in UI bugs
Component
Dasharo Tools Suite
Device
QEMU Q35 Emulator
Dasharo version
No response
Dasharo Tools Suite version
v2.4.0
Test case ID
No response
Brief summary
Entering empty password results in DTS being stuck at Dasharo DPP credentials have been saved until enter has been pressed and then:
Your credentials give access to:
Dasharo Pro Package (DPP): NO
DTS Extensions: YES
Checking for available DTS extensions...
mc: <ERROR> Unable to list folder. Access Denied.
Press Enter to continue.
We have mc error and also for some reason DTS Extensions: YES
Pressing Enter again results in UI freezing again but this time after clearing current UI (so we see only black screen). We have to press enter to show UI. After that every screen refresh (each key press) stops at blank screen and we have to press Enter to show anything.
Not only that but after that I couldn't use working credentials, DTS would display that they were ok but wouldn't save changes. It's possible that it is separate bug and it's impossible to change credentials after loading them once
How reproducible
100%
How to reproduce
- Start DTS in QEMU
- Enter any DPP e-mail, e.g. I tried
abcd - Enter empty password
Expected behavior
- Don't allow empty password
- Or fail gracefully (no mc errors, don't show
DTS Extensions: YESif they are not available) - Don't freeze without informing user that they have to press something
Actual behavior
- Allows empty password
- follow up messages shouldn't be misleading and shouldn't display used command errors (mc in this case)
- Waits for user input after displaying
Dasharo DPP credentials have been saved(without informing user that they have to do something), then again each time it clears screen (waits for user input on empty black screen)
Screenshots
No response
Additional context
No response
Solutions you've tried
No response
Possibly (partial) duplicate of https://github.com/Dasharo/dasharo-issues/issues/1156 (the first point). From what I remember fix for empty credentials was done here: https://github.com/Dasharo/meta-dts/releases/tag/v2.1.2 but underlying issue (screen freeze) wasn't fixed. Now we have regression (different errors, no check for empty password?) and underlying issue also came back. Maybe we should find the cause of this freeze along with fixing empty password bug to make sure it never comes back (and add test for this)
Hi! I’d like to work on this issue as part of the bounty program. I've reviewed the bug description and plan to address the following:
- Prevent submission of empty passwords
- Ensure accurate messages for DTS Extensions and
mcerrors - Fix the screen redraw/freezing behavior after empty input
I've already started setting up the QEMU environment and will aim to submit a fix within a week. Please assign this issue to me if it's still available. Thanks!
@sachin21212121 welcome on board and good luck with the task. @DaniilKl @m-iwanicki please support @sachin21212121 in delivering expected results.
I've already started setting up the QEMU environment and will aim to submit a fix within a week. Please assign this issue to me if it's still available. Thanks!
Great. Feel free to ask questions and report any other issues or unclear documentation.
Sure @DaniilKl , thanks!
I've already started setting up the QEMU environment and will aim to submit a fix within a week. Please assign this issue to me if it's still available. Thanks!
Great. Feel free to ask questions and report any other issues or unclear documentation.
Sure @DaniilKl, thanks!
