dash.js icon indicating copy to clipboard operation
dash.js copied to clipboard

Why dashjs is declaring devDeps as deps and useless files in npm package?

Open Mister-Hope opened this issue 1 year ago • 1 comments

I am VERY curious that how dashjs "needs jsdoc" at runtime, can anyone explain that?

By installing dashjs, I introduced hundreds of useless deps in my project, but all I need is just the main file. 100+ more packages like jsdocs even appears in the latest 4.7.3. I don't want my node_modules be a trash bin.

Also, why should the final docs be placed in dashjs package:

image

Are you expecting someone to serve your docs by using dashjs packages?

Your guys are even not including source files into the package, but choose to package docs/jsdocs and even a "githook.js":

https://github.com/Dash-Industry-Forum/dash.js/blob/development/githook.js

Don't you think that it's a little bit ridiculous?😅 Don't tell me you are expecting user to reuse the file to proceed npm run lint

Mister-Hope avatar Dec 09 '23 13:12 Mister-Hope

Will this be effective in reducing the bundle size sent to client?

Library Size CDN
Dash.js 0.75MB http://cdn.dashjs.org/latest/dash.all.min.js
ShakaPlayer [dash + hls] 0.53MB https://cdn.jsdelivr.net/npm/shaka-player/dist/shaka-player.compiled.min.js
HLS.js 0.39MB https://cdn.jsdelivr.net/npm/hls.js

How is ShakaPlayer lighter than dash.js while implementing both dash & hls?

n-ce avatar Jan 29 '24 06:01 n-ce

Addressed in #4469.

The bundle size is not reduced by that.

dsilhavy avatar Aug 15 '24 16:08 dsilhavy