dash.js icon indicating copy to clipboard operation
dash.js copied to clipboard

Events contract is a bit broken

Open AfLosada opened this issue 1 year ago • 1 comments

I think that the Contract between these two fragments is a bit broken https://github.com/Dash-Industry-Forum/dash.js/blob/377d60a97c7076bb8097abdca875130518920397/index.d.ts#L417-L425 https://github.com/Dash-Industry-Forum/dash.js/blob/377d60a97c7076bb8097abdca875130518920397/index.d.ts#L1237 The event that is actually being sent by the videoplayer has a form like this

interface Event = {
     type: string,
     event: { 
          type: string; 
          duration: number; 
          presentationTime: number;  
          id: string | number; 
          messageData: string; 
          eventStream: EventStream; 
          presentationTimeDelta: number; 
     } 
}

I know this is a develoment branch, so this hasn't been release, but I thought I would let you know in case I'm onto something or if I am missing something.

AfLosada avatar Apr 25 '23 16:04 AfLosada

Typescript file will be checked as part of the v5 work.

dsilhavy avatar Nov 16 '23 12:11 dsilhavy