dash.js icon indicating copy to clipboard operation
dash.js copied to clipboard

Published 20 hours ago • verified publisher icon Dash-Industry-Forum

separate settings matcher to work on each property individually

Open stschr opened this issue 2 years ago • 1 comments

This change should fix both https://github.com/Dash-Industry-Forum/dash.js/issues/3961 and also https://github.com/Dash-Industry-Forum/dash.js/issues/3967 More intense testing or samples deemed beneficial.

stschr avatar Aug 05 '22 14:08 stschr

@stschr Thank you for this, looks really good. Before I do the final code review: Did you already sign the feedback agreement: https://dashif.org/docs/DASH-IF-Feedback-Agreement-3-7-2014.pdf : If not can you please send the signed agreement to me to forward to DASH-IF.

Thanks

dsilhavy avatar Sep 05 '22 07:09 dsilhavy

In addition to the two comments above: There is a reference to mediaController.matchSettings in TextController which needs to be resolved according to the new logic as well.

dsilhavy avatar Oct 10 '22 12:10 dsilhavy

On TextController referencing mediaController.matchSettings : At least this issue is fixed now, as I re-added the old code as interim solution. Bad thing is that we have duplicated code now.

I can work on the TextController as well, but from what I have seen, there are no related unit tests so far. so, this might take a little longer... All audio related code should be fixed.

Up to you (@dsilhavy) to decide whether to close this PR now and file a new issue, or to keep this open an dwait for some more code on text.

stschr avatar Oct 13 '22 17:10 stschr