dash.js icon indicating copy to clipboard operation
dash.js copied to clipboard

Out-of-date fragmented track cues not cleared on video buffer cleanup during playback

Open jbree opened this issue 3 years ago • 4 comments

I have noticed that player teardown can take a long time (5+ seconds) after long-playing videos with a high volume of cues. It appears that dash.js does not clear cues from a fragmentedTrack until the player is torn down completely.

I believe fragmented track cues should be handled similarly to embedded track cues in the onVideoBufferCleared(e) function, but would like to be disabused of this notion if I am incorrect.

https://github.com/Dash-Industry-Forum/dash.js/blob/42d584b6e088af0ed3045a8a26fcf97c35b09f07/src/streaming/text/TextSourceBuffer.js#L584-L591

jbree avatar Apr 30 '21 18:04 jbree

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Feb 12 '22 12:02 stale[bot]

unstall

dsilhavy avatar Feb 14 '22 10:02 dsilhavy

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Jul 15 '22 02:07 stale[bot]

unstall

dsilhavy avatar Jul 15 '22 06:07 dsilhavy

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Dec 13 '22 00:12 stale[bot]

unstale

dsilhavy avatar Dec 13 '22 06:12 dsilhavy

Fixed in #4305

dsilhavy avatar Nov 13 '23 18:11 dsilhavy