dash.js icon indicating copy to clipboard operation
dash.js copied to clipboard

Update imscJS prod dependency

Open mlasak opened this issue 5 years ago • 10 comments

The imscJS dependency should be updated to 1.1.1

  • [ ] check why simply updating the module will lead tests to fail
  • [ ] fix the issues in usage of the module to be able to update

mlasak avatar Aug 18 '20 13:08 mlasak

@mlasak There is no IMSC 1.1.1 - the currently active IMSC versions are 1.0.1, 1.1 and 1.2. Each in turn adds features to the previous, but there are no breaking changes in the sense that an IMSC 1.2 processor can play back an IMSC 1.0.1 document; however a document using features only defined in IMSC 1.2 would need an IMSC 1.2 processor, of course.

I agree that we should make sure that the version of imsc.js that is used in dash.js is updated to the latest. CC @palemieux also.

nigelmegitt avatar Aug 18 '20 13:08 nigelmegitt

Hi @nigelmegitt, yes thanks and sorry for not being specific enough. I was referring to the node.js dependency version, not the W3C recommendation. I'll update the title to use imscJS to make this more clear.

mlasak avatar Aug 20 '20 08:08 mlasak

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 26 '21 14:02 stale[bot]

@mlasak Let me know if you need any assistance with this. The recent releases of imscJS fix significant bugs.

palemieux avatar Feb 26 '21 15:02 palemieux

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Jul 26 '21 17:07 stale[bot]

unstall

dsilhavy avatar Jul 27 '21 06:07 dsilhavy

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Feb 12 '22 12:02 stale[bot]

unstall

dsilhavy avatar Feb 14 '22 10:02 dsilhavy

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Jul 15 '22 02:07 stale[bot]

unstall

dsilhavy avatar Jul 15 '22 06:07 dsilhavy

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

stale[bot] avatar Dec 13 '22 00:12 stale[bot]

unstale

dsilhavy avatar Dec 13 '22 06:12 dsilhavy

Hello, we are keen to update the version of imsc.js that is bundled with dash.js as there are a number of bug fixes and performance improvements that we feel are important.

I noted a task "check why simply updating the module will lead tests to fail". I updated the version myself in a local branch and found that all tests are passing successfully. @mlasak could you describe the issue you were seeing yourself? Based on the creation date of this ticket, I note that you have tested against dash.js v3.1.2 or lower. Perhaps these issues have been resolved since major update to 4.x.x?

@mlasak can you describe the "issues in usage of the module to be able to update"? Were these dash.js integration issues or imsc.js compatibility issues with your own content?

One of our partners has confirmed that they are successfully using the latest version of imsc.js with their live dash stream outside of dash.js and we're keen to bring parity with the bundled version here.

Any thoughts on the best way forward would be appreciated.

vodlogic avatar Feb 27 '23 16:02 vodlogic

Latest imscJS release is 1.1.3 currently.

nigelmegitt avatar Feb 27 '23 16:02 nigelmegitt