DASH-IF-Conformance icon indicating copy to clipboard operation
DASH-IF-Conformance copied to clipboard

Feature/add dvb dash 2017

Open wschidol opened this issue 2 years ago • 4 comments

Even though the code base already contained DVB-DASH 2017 profile tests, the profile string itself was not recognized. This PR fixes this and "legalizes" urn:dvb:dash:profile:dvb-dash:2017. Note that this PR also brings in #589 so it makes sense to approve that first. It can be debated whether this fixes a bug or adds a feature. I opted for the latter and called this a feature but it could go either way.

wschidol avatar Jun 24 '22 11:06 wschidol

Even though I believe this is valid schematron, I get warnings when trying to compile this with create_val_schema.sh. Investigating.

wschidol avatar Jun 27 '22 13:06 wschidol

The code now compiles with create_val_schema.sh. I tested on all the example mpd files and the results are essentially identical except for a changed diagnostic message when the the profile string does not validate.

wschidol avatar Jun 28 '22 10:06 wschidol

@wschidol Can you please rebase that based on development. Just merged #589

dsilhavy avatar Jul 08 '22 11:07 dsilhavy

@wschidol Can you please rebase that based on development. Just merged #589

Done.

wschidol avatar Jul 11 '22 10:07 wschidol