HyperBone icon indicating copy to clipboard operation
HyperBone copied to clipboard

reserved identifier violation

Open elfring opened this issue 8 years ago • 3 comments

I would like to point out that identifiers like “_EFLAGS” and “_CPU_VENDORdo not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

elfring avatar Feb 26 '17 11:02 elfring

It's unlikely that I'll change the code to be fully compatible with C standard. I doubt it can cause any real conflicts and compiler will give warning if anything goes wrong.

DarthTon avatar Mar 06 '17 14:03 DarthTon

How do you think about to avoid that this software depends on undefined behaviour?

elfring avatar Mar 06 '17 14:03 elfring

It doesn't depend on it. It may have undefined behavior because of reserved identifier conflict, but it's the smallest issue here.

DarthTon avatar Mar 06 '17 14:03 DarthTon