Aurélien D.

Results 162 comments of Aurélien D.

Actually the `_srv_parse_set_id_from_prefix()` at the end of `_srv_parse_tmpl_init()` is not needed anymore since 7223296, it was probably overlooked. Thus the fix is even simpler: ```diff diff --git a/src/server.c b/src/server.c index...

Meanwhile (waiting for the fix in the next 3.0 release), a good workaround would be to target the server using numerical id (`#` followed by id instead of name), since...

What you see is probably the result of UAF (use-after-free) since the memory location may be reused for something else once it is freed, but the above fix addresses the...

I failed https://github.com/haproxy/haproxy/commit/fa90a7d313703cfc4e1b41d258d0d6d470ffe967 bugfix `free_email_alert()` will always try to free email alerts settings without checking if the mailer name was already resolved. (name hint and pointer share the same memory...

``` haproxy[3630401]: FATAL: pool inconsistency detected in thread 1: tag mismatch on free(). haproxy[3630401]: caller: 0x5559a9492566 (__stksess_kill+0xf6/0x11d) haproxy[3630401]: item: 0x7f839928e750 haproxy[3630401]: pool: 0x5559a9f3a280 ('spoe_appctx', size 200, real 208, users 2)...

Remaining one is potential null-deref: `3) In file mux_h2.c:6607`, what do you think about this one @capflam?

cli commands use general purpose buffers that are limited in size to `tune.bufsize` (defaults to 16k) With a CLR file > tune.bufsize the command will fail. Before 498520fdf505f05cde2f99c70c4e98fe90098961 no error...

>If I may recommend to consider adjusting of return codes. Even if CRL set command failed due to lack of buffer area haproxy could return an error. I use a...

Hmm, looking at the code, I don't think there is an issue there: ```c chunk_appendf(msg, " %p: id=%s(%s,%s) addr=%s:%d app_state=%s learn_state=%s last_status=%s", peer, peer->id, peer->local ? "local" : "remote", peer->appctx...