darkstar
darkstar copied to clipboard
DarkstarProject
Casket pr
Added all the remaining zone casket npc scripts. Added all zone mixins for caskets. Added all temp items that caskets use. Edited 2 effects that were not implimented.
I have spent many hours going over the drop rates of items, if anyone wants to make adjustments feel free to PR them if you feel they are off but right now they are as retail as i could get with limited info, but they feel right when playing.
I double-checked all the tabled itemIds against the database to see if they matched the items named in LUA comments.
Found no incorrect itemids. :white_check_mark:
~~Only discrepancy, if you can call it that, is that the commented item names are misordered for~~
~~dsp.zone.THE_SHRINE_OF_RUAVITAU regionalItems = {11040, 10951}, -- Weaver's Torque / Terminus Earring~~
~~[dsp.zone.THE_BOYAHDA_TREE regionalItems = {11038, 10948}, -- Carver's Torque / Dragonkin Earring~~
edit: was fixed by OP
For range hints on chest examine the high/low number is random number between 5-20 added/subtracted to the correct answer.
If the high/low number is greater than 98 or less than 11 the message changes to less/greater than
Credit goes to byrth for those findings, you can find detailed info in the boxdestroyer addon for windower or my ashita port of boxdestroyer Thief's tools range is 8-32, living key is 6-24 and skeleton key is 4-16
You know this is one thing I was sad about, I’m not sure if I can get this to be compatible with box destroyer, I might have to do some research into what packet gets returned so I can get it pushed so box destroyer can pick it up
You know this is one thing I was sad about, I’m not sure if I can get this to be compatible with box destroyer, I might have to do some research into what packet gets returned so I can get it pushed so box destroyer can pick it up
I think should just be the event packets (and messages?) that reach the client.
You know this is one thing I was sad about, I’m not sure if I can get this to be compatible with box destroyer, I might have to do some research into what packet gets returned so I can get it pushed so box destroyer can pick it up
that think should just be the event packets (and messages?) that reach the client.
messageSpecial for 0x2A, what isn't compatible?
not sure yet, i need to do some testing, ill let update if i find anything, it might be that dsp send the packet different
Lockpick is windower 5. Boxdestroyer should be working, are you on windower or ashita?
Make sure you are using the one in the launcher? What specifically isn't working?
I'm going to work on adding the extra hints from different keys next, once this is ok
Only discrepancy, if you can call it that, is that the commented item names are misordered for
dsp.zone.THE_SHRINE_OF_RUAVITAU regionalItems = {11040, 10951}, -- Weaver's Torque / Terminus Earring
[dsp.zone.THE_BOYAHDA_TREE regionalItems = {11038, 10948}, -- Carver's Torque / Dragonkin Earring
Oh i fixed this too btw
Id like to make a note for this not to get merged until the problems of claiming with pets is resoloved please, as it will break as it currently is, as pet abilities do not claim pysical and magical.
Casket Prowess from Regime needs to be divided by 100. It is not in percentage form and it is causing 100% casket rate with casket prowess.
Casket Prowess from Regime needs to be divided by 100. It is not in percentage form and it is causing 100% casket rate with casket prowess.
I don't see it being touched in the PR and in master branch PROWESS_CASKET_RATE is still unimplemented.
The effect isn't it. But he grabs the power straight off the effect, which is scripted in regimes.
So, there is no mod, no, but the effect still has power.
Prowess is multiple effects:
-- *Prowess increases not currently retail accurate.
-- GoV Prowess bonus effects, real effect at ID 474
PROWESS_CASKET_RATE = 777, -- (Unimplemented)
PROWESS_SKILL_RATE = 778, -- (Unimplemented)
PROWESS_CRYSTAL_YEILD = 779, -- (Unimplemented)
PROWESS_TH = 780, -- +1 per tier
PROWESS_ATTACK_SPEED = 781, -- *flat 4% for now
PROWESS_HP_MP = 782, -- Base 3% and another 1% per tier.
PROWESS_ACC_RACC = 783, -- *flat 4% for now
PROWESS_ATT_RATT = 784, -- *flat 4% for now
PROWESS_MACC_MATK = 785, -- *flat 4% for now
PROWESS_CURE_POTENCY = 786, -- *flat 4% for now
PROWESS_WS_DMG = 787, -- (Unimplemented) 2% per tier.
PROWESS_KILLER = 788, -- *flat +4 for now
these are effect IDs and the effect was never implemented before this pr and I did not see it earlier, but maybe I missed it.
Pretty sure real problem lies in regimes.lua not having a specific case for the right prowess and applying to big a value to the wrong damn one because of it.
And fix that rebase @Omnione
Right that should all be good now, tested everything and it seems to be working well, cheers for helping Teo.
Maybe we could test in oldschool? Metal should be online right now and I'll go online late in the evening with Jameson and Junioat 9:30PST
Been using this PR on my server:
- Quicksand Caves seems to be missing?
- Sanctuary of ZiTah gives japanese characters on chests
- I think you already got the Tahrongi issues
- Yhoat "range" hints don't seem to give numbers
- Also, on occassion after interacting with a chest everything becomes "too far" to interact with, and if you hit a zone line you go to an "unknown" zone.
m241dan your right, • seems i missed quicksand caves. • Sanctuary of ZiTah same issue as Tahrongi. • Yhoat range hints, not sure about that, ill have to dig a bit deeper. • that last thing about zoning, wtf, lol i have no idea how that is happening.
M241dan if you need to ask me anything you can hit me up on the dsp discord, i go by MrSent on there.