bcnmcrap true detection issue

[Wiggo32]

I have:

• [x] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
• [x] checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) :

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) :

https://github.com/DarkstarProject/darkstar/blob/746b0aeb8a54452eeaf62d754268a5e7be0730f0/src/map/utils/mobutils.cpp#L807

current retail as it stands now does not make all dynamis mobs have true detection. so this line would be set to false for that. though, dynamis D may? idk anything about dynamis D. So, whatever the best way to handle that is.

[ibm2431]

For record, Dynamis D mobs are true detection.

(This feels like something that should be handled by scripts or DB anyway.)

[helixhamin]

I thought mobs true detect was handled already? Maybe I am wrong. In the mobs family system table, it has detects type.

[TeoTwawki]

old style dyna all mobs were true detect so somebody hard-coded it instead of setting them the normal way. mob families has the detection type (sight/sound/blood/magic) and I think pools has the true-detect flag (on/off) and agro/linking (also both on/off). I think it all should have been one combined mask in the group or pool table personally.

[Hozu]

I believe the reason it was hardcoded for all Dynamis spawns is because some mobs are shared outside of it - specifically the Kindred (jobs) in the Uleguerand Range. Those would need to be properly separated from the Dynamis versions.

[TeoTwawki]

they share families I dunno if they share pools (they should not share pools since they are completely diff mobs, but would not surprise me to find they DO). a long while back true detect and the detection type were combined and moved around, but the hardcoding of this predates all of that - it was just a quick way out to hit the entire zone without having to set them individually

[Wiggo32]

can update the hardcoding to check for dynamis d zones only and not touch the regular dynamis... ?

[ibm2431]

Just remove the hardcoding altogether. No need to add additional hardcode for content that isn't currently implemented (and for an incorrect solution at that).

Whenever someone adds Dynamis D mobs they can just set true detection in pool or w/e it is by then.

edit: Maybe check the current NMs' pools for those that should still be true detection and update DB if necessary. I think this is only applicable to the Mega Bosses, as I don't recall the timed spawn NMs being true detection (in Neo Dynamis).

[wrenffxi]

I removed the "Dynamis true detection" default from core in #6181. It's possible (likely) that some of the NMs need some true-detection fixing in their specific pool data, but that can go in the general Dynamis TODO issue (added it). I think this issue can close.

Currently, Dynamis mobs don't share pools with non-dynamis mobs.