darkstar
darkstar copied to clipboard
DarkstarProject
Certain gear not displaying properly when using gearsets lockstyle function
I have:
- [x] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
- [x] checked the commit log to see if my issue has been resolved since my server was last updated
Client Version (type /ver in game) :
30190430_0
Source Branch (master/stable) : no idea what this even means
Additional Information (Steps to reproduce/Expected behavior) : I am currently playing on the Nocturnal Souls server, where I have run into this issue.
Certain pieces of gear are not displaying their armor models correctly when specifically using the lockstyle function of the in game gearsets.
These pieces of gear include the Ceremonial Dress, Novennial Dress, and Novennial Boots.
When equipping these pieces of gear normally, then using the /lockstyle text command, there seems to be no issue with the models displaying correctly. However when one uses the gearset function to stylelock these pieces there are parts that do not display properly.
Shown in the screenshots below are the armor models being displayed correctly when equipping the items normally, and then comparison screenshots of how they incorrectly appear when using the lockstyle function of the in game gearsets.
The Ceremonial Dress does not display the hand area as it normally should, and will instead overlap whichever piece of gear is actually equipped in that slot, or display the naked model for that slot if nothing is equipped there.
The Novennial Dress has the same error in display as the Ceremonial Dress listed above, and as shown in the screenshots below. The Novennial Boots display as if half of the characters legs are clipping over the armor model.
With all of this said, I do realize this isn't a major issue that warrants priority over game breaking issues, but it is something I would not mind seeing addressed should those working on the game have time, and any efforts are appreciated. Thank you.
Source Branch (master/stable) : Master
Sorry, I got clarification on what this meant.
The issue has to do with gear that locks out other slots. Specifically, that gear needs to set the locked slot to the same (offset?) value as the slot the particular equip is in. Currently, locked slots are being set to whatever is in the hands slot, or the default if nothing is set.
As a workaround for in-game use, actually equip the gear and use /lockstyle on, instead of putting the gear in an equipset and using /lockstyleset.
Yea, I figured that out in the process of trying to troubleshoot exactly where the issue lay. Thnx for the insight as to what specifically is causing the issue. Should I close this ticket, or leave it to a mod to decide if they want to keep it open?
Looking at the dress + THF AF hands: Ignoring /lockstyle, does the hands item get properly removed when equipping the dress (either manually or from an equip set)? Is equipsets allowing you to have both dress and hands in the same equipset? Or is this issue limited just to the display?
Yes, this only happens when using the lockstyle feature of the in-game gearsets. If you equip the item normally it will display the armor model as it should, which you can then use the /lockstyle text command to lock the gear appearance.
Ignoring /lockstyle, are equipsets allowing both items in the set?
Can one use /equipset to equip both the dress and hands?
The Dress and the hands are the same item, it's an item that has the descriptor of (cannot equip hand gear), which is in theory where the problem lies?
Descriptor? No, description don't matter, implemented behavior does. We can remove the reserved slot from the item and allow you to normally equip, as long as the client doesn't freak out. What he means is, go to an equipset and define both the body and hands, and see if it lets you equip both, even though you should not be able to.
y'all gettin confused
the equipset is using an item that covers two slots. the server is forgetting to check for multi-slot items when applying an equipset as lockstyle (ie. only the model id), causing the actual equipment to show through
@teschnei So the problem is only the display, and the server isn't forgetting to check for multi-slot items when equipping an equipset?
if that was the case, the fourth picture wouldn't look like that - those are the default (nothing equipped) mithra hands and legs
I fired up my server to play with it some, some things I've noticed thus far: A) Equipset is allowing you to define pieces in both slots (this does not happen on retail, it will immediately kick the other item off the equipset)
B) Equipset is not letting you equip both slots. You can't trick an equipset to let you equip both Novennial Legs + any feet with either both in the equipset (it will choose the feet slot), or by having the equipset be just one of the items you try to /equipset while you're currently wearing the other item. (This is what I wanted to make sure of.)
C) When attempting to stylelock an invalid equipset (Novennial legs and any defined feet), it will attempt to blend the two items in the equipset, not legs + whatever you have currently equipped in feet
D) If you attempt to stylelock with just Novennial legs in the equipset, when currently equipped with any foot item, it will try to blend the legs with your currently equipped foot item
E) If you attempt to stylelock Novennial legs + blank feet in the equip set, when wearing nothing in either slot, it will try to blend Novennial legs with default naked feet
F) E will also occur if you have any non-Novennial legs currently equipped in the legs slot
G) If you attempt to stylelock Novennial legs + blank feet, while having Novennial legs actually equipped, you end up with the normal looking Novennial legs only, no blended default feet
H) G also occurs if you have a different foot-locking piece actually equipped (Dinner Hose) when you try to stylelock the Novennial Legs, it doesn't have to be the same piece being locked
I) But if your equipset is Novennial Legs + Remove feet (Red X), you will end up with blended Novennial + Default, even if you're currently equipped with a valid Novennial/Dinner legs