darkstar
darkstar copied to clipboard
Earthbreaker shouldn't wipe shadows like AOE magic
I have:
- [x] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
- [x] checked the commit log to see if my issue has been resolved since my server was last updated
Client Version (type /ver
in game) : 30190328_2
Source Branch (master/stable) : master
Additional Information (Steps to reproduce/Expected behavior) :
Weird one since it's a magical AOE move, right?
I vaguely tried to take a crack at submitting this directly as a PR but I'm not quite sure how to update. Earthbreaker is currently defined as a MobMagicalMove with param WIPE_SHADOWS
when it should be work like a multihit AOE using something like numhits
.
I found a video showing Earthbreaker being absorbed by shadows twice, timestamped here: https://youtu.be/hy3GPJc3kEw?t=128 (turn your volume down) https://youtu.be/hy3GPJc3kEw?t=407
Not sure how many the max numhits should be, though if I had to bet I'd go with 3 or 5. Any help on how to slide this parameter into a MagicalMove would be appreciated.
Oh, and you can chalk up the inaccuracy to #wikifails @TeoTwawki
Related: unsure if this same issue should apply to it's little brother Earth Pounder but I rather strongly suspect it does.