Fixing bugs & new features - after the update to v10

[mimiski]

Disclaimer: this is a list for curation of bugs & new feature requests. Feel free to modify it. Later on separate issues can be created for each accepted feature request.

Bugs

• [ ] increase FOV on mortars

• [ ] remove artillery from maps that do not have radios as the number of available artillery barrages is now visible in binoculars: Pegasus, Omaha

• [x] bugged mortar animations See the video: link

• [ ] increase the area of no constructions around main spawns containing supply caches with 8000 supplies on maps like Hattert to make it harder for artillery batteries to be built

• [x] when the last artillery target expires and that marker was active the "No available artillery targets" text does not show up

• [x] there is no limit on number of constructable LeIGs on Hattert

• [x] #1329

• [ ] increase the resupply interval for smoke shells on mortars in DHResupplyStrategy.UpdateTime for underployed mortars or through DHMortarVehicleWeapon.ResupplyInterval for deployed mortars

• [ ] decrease the resupply interval for HE shells on M1927

• [x] broken rendering of body models when head is blown off after an explosion

• [ ] artillery kill feed is inconsistent - shouldn't the victim always get the artillery kill feed?

• [ ] rally points generate infinite resupply of ammo for MGs carried by players https://user-images.githubusercontent.com/56321463/137603021-7730e668-b536-4445-bc20-be95f58e684a.mp4

• [ ] bugged smoke shell explosions on mortars, the shells land and do not disappear as long as smoke is being emitted

• [ ] sometimes it is impossible to reenter mortar, e.g. 1) play St Marie Du Mont 2) set up the mortar on a swamp (see the attached screenshot) 2) leave the mortar 3) try to reenter it 4) it is not possible

• [ ] M116 (the American howitzer) and M1927 (the Russian howitzer) are missing normal gunsights

• [ ] bugged deployed mortars on uneven surfaces such as trenches in E5 on Klin Advance, circumstances: yellow puzzles (lag), symptoms: impossible to change pitch on the mortar

• [ ] bugged artillery gun limit, once it's reached it sometimes does not go down even if you destroy guns, needs more investigation

• [ ] SLs: marker timeout is not displayed when the player is dead

• [ ] Axis mortar: incorrect shading of pitch dials - shading looks unnatural, the pitch dial needs to be as long as the shading overlay is

New features

• An elevation difference readout on the targets (e.g. it is very significant for the ranging if you are like 20 meters below the target in elevation)
• A different splash icon if it hits something "in the way" (e.g., if it hits a tree or the side of a building)
• The little arrow for showing when your shots are way wide of the mark
• Add 'artillery' text channel visible for artillery spotters and artillery operators

Common and unrelated bugs (create own issues for these)

• bullet impacts of Enfield - the splash is always horizontal on some textures such as walls of the church on Osterbeek https://user-images.githubusercontent.com/56321463/137516161-b3c84781-f7f3-4452-9f10-f19bec9a833c.mp4

[shiftycats]

there is no limit on number of constructable LeIGs on Hattert

Limits are not setup on any maps, and we're not going to manually assign all of them. Artillery limits need to be enforced globally in the code.