DarkestHour
DarkestHour copied to clipboard
DarklightGames
Marder, halftracks & bren carrier - MG muzzle flash not visible when player raises head above ironsights
Originally reported by: Colin Basnett (Bitbucket: cmbasnett, GitHub: cmbasnett)
- Bitbucket: https://bitbucket.org/darklightgames/darkesthour/issue/123
┆Issue is synchronized with this Trello card
Original comment by Bitbucket: Matt_UK, GitHub: Matt_UK:
This isn't a bug, it's a specific piece of code in state ViewTransition, which hides the muzzle flash when gunner's head is raised above the sights. It is there in all the open vehicle MGs where you can raise your head like this above the gun.
The function override comment reads "Hack - Turn off the muzzle flash in first person when your head is sticking up since it doesn't look right".
It's not perfect, but better than the displaced, floating muzzle flash you'd see otherwise.
May be possible to solve the muzzle position properly, but not quick or easy. Would need investigation and trial and error. Being realistic, I think this has to be a 'maybe' for a future release.
Original comment by Colin Basnett (Bitbucket: cmbasnett, GitHub: cmbasnett):
Not high priority, putting this on hold.
Original comment by Bitbucket: Matt_UK, GitHub: Matt_UK:
In commit 7d3baa4 I've worked this code into generic functionality in DHMountedTankMGPawn. Does not change the problem or the hack-ish workaround; it just removes the need for identical function overrides in different vehicle classes. Now just set bHideMuzzleFlashAboveSights=true in def props. Noting it here just to keep track of where the code is.
Removed from v8 milestone. Very minor issue. Worst effects long since mitigated. No easy solution jumps out. Never really done any work on this beyond the 2015 commit. One that may well never get fixed fully.
