DarkflameServer icon indicating copy to clipboard operation
DarkflameServer copied to clipboard

Added windows build commands to build script

Open HailStorm32 opened this issue 2 years ago • 3 comments

Added "intelligence" to the build script to run different build commands if on Windows.

Also, given this uses the OSTYPE variable, the ability to run different commands for different OS's could be added in the future.

HailStorm32 avatar Aug 14 '22 02:08 HailStorm32

Correct, my only reason for moving the binaries was because they couldn't run in the Release directory. However, you bring up a valid point in that the way I went about it wasnt ideal.

My question then is this. Do you want me to remove the part the moves the binaries and just tell the user to do that manually, or move the movement of the binaries to cmake?

As it stands now, building on Windows requires the movement of files. It's not just the dlls that its missing, but also the log folder and .ini files. Hence why I moved only the binaries, as it was less to move. I presume the rework of the build system will take this into account?

HailStorm32 avatar Aug 14 '22 20:08 HailStorm32

Yes the fixing of the build system to actually work on native windows will be fixed in #670 .

EmosewaMC avatar Aug 14 '22 21:08 EmosewaMC

@EmosewaMC removed OS check and switched to cmake

HailStorm32 avatar Aug 14 '22 23:08 HailStorm32