DarkflameServer
DarkflameServer copied to clipboard
DarkflameUniverse
refactor(docker): improve docker experience
This PR should add some promised improvements for users who are using docker.
My current goal is it to improve the following things:
- [X] Auto detect client type and root folder
- [X] Allow to manual set client type
- [X] Notify darkflame server if setup fails
- [X] Database hardening
- [x] Wait for the database to be ready #417
- [x] Add a wrapper for
MasterServer -ato make sure the server is ready - [x] Create docker images via GitHub Actions and push it to github registry
- [ ] Update documentation
Do you want to address #399 here as well? (in case it is really only a small change as suggested in https://github.com/DarkflameUniverse/DarkflameServer/issues/399#issuecomment-1030998040)
@Marcono1234 can you try whether the latest commit resolves the issue or not?
Is this blocked on something that one could help with? If I understand correctly a fix for #399 is included in this. It would be great if this could be merged eventually because as it stands right now the LU experience in docker isn't great because there is no way to add friends.
Is this blocked on something that one could help with? If I understand correctly a fix for https://github.com/DarkflameUniverse/DarkflameServer/issues/399 is included in this. It would be great if this could be merged eventually because as it stands right now the LU experience in docker isn't great because there is no way to add friends.
I just didn't have time for this. But if this is desperate needed, I could make the missing changes in another PR when I have time again.
@TheNoim Well I wouldn't call it "desperate", this is just a game after all. Thank you for your work on dockerizing all of this btw!
Quick fix you may want to implement in this PR as well: Step 1 in Docker.md says "Copy .env.example." This is impossible since .dockerignore ignores .env.example in this repo :)
This is impossible since .dockerignore ignores .env.example in this repo :)
Shouldn't be an issue since .dockerignore only ignores files for the Docker build context. I bet you're thinking of .gitignore which doesn't track changes for ignored files and so they won't be included in the repo.
