BUG: Witch's Surf Broom doesn't smash enemies properly

[MustacheMan2]

Make sure you've done the following:

• [X] I have checked that this issue has not already been reported.

• [X] I have validated that this issue is not a syntax error of either MySQL or SQLite.

• [X] I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

Issue Description

Enemies will spawn back with no damage taken after killing them with the Witch's Surf Broom. Skill system issue?

Reproduction steps

Use the Witch's Surf broom on an enemy, it will spawn back shortly afterwards (or health will not sync).

Expected Behavior

It should kill the enemy or deal the intended damage

Environment

ubuntu server

[Xiphoseer]

This led me to a bug in LU-Explorer, because a hit_action on a ForceMovement is not that common and might not be implemented. That may or may not be the cause this doesn't work.

[Xiphoseer]

These lines specifically look a bit suspicious, especially that the hit enemy action is executed twice, but the hit faction one not at all... https://github.com/DarkflameUniverse/DarkflameServer/blob/b8c1f7629e4dc351ed24a2a8618a9c398a22d475/dGame/dBehaviors/ForceMovementBehavior.cpp#L78-L80

[aronwk-aaron]

These lines specifically look a bit suspicious, especially that the hit enemy action is executed twice, but the hit faction one not at all...

https://github.com/DarkflameUniverse/DarkflameServer/blob/b8c1f7629e4dc351ed24a2a8618a9c398a22d475/dGame/dBehaviors/ForceMovementBehavior.cpp#L78-L80

this was actually the cause of the schooner hitting twice. Fixed in #878. However, this does not fix the witches surf broom (aka this issue)