BUG: Mythran appearance/gminvis behaviour is buggy

[sersorrel]

Make sure you've done the following:

• [X] I have checked that this issue has not already been reported.

• [X] I have validated that this issue is not a syntax error of either MySQL or SQLite.

• [X] I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

Issue Description

When you gmlevel yourself from 0 upwards, you get a chat message saying you've become invisible, but that doesn't actually seem to work. You see yourself as translucent, but other players see you as normal, even after you or they relog.

It also seems like you're meant to appear as a Mythran if your gmlevel is nonzero, but this also doesn't seem to work properly. You don't appear to yourself as a Mythran until you relog or switch maps, and others don't see you as a Mythran until they relog (or presumably switch maps), as far as I can tell. The nameplate above your head changes immediately, though (text goes blue, and either shows "Mythran" or "[GM]" and your name (I think this depends on whether the observer is currently a GM?)).

Switching back to gmlevel 0 while people see you as a Mythran makes the ordinary white nameplate appear, but your model doesn't change back from the Mythran one until the observer relogs.

(it's very possible that some of this is not entirely accurate, sorry, I don't really have a good way of testing apart from "roping in some friends with limited patience"; it's also possible that this is how it was in live, there are some screenshots on the wiki of mismatched Mythran models and nameplates, apologies if that's the case)

Reproduction steps

• have two accounts logged in
• /gmlevel 1 on one of them
• the other player can see you, but you should be invisible; you don't look like a Mythran, but you should
• log out and log in again (or "switch minifigure" to the same minifigure), or go to a different map
• now you look like a Mythran, at least to yourself

Expected Behavior

"whether you appear as a Mythran/are invisible" should be the same on both your screen and the screens of other players.

Environment

Ubuntu 20.04 aarch64 with #111 (yes, I'm planning to switch to #231 when I get a chance) plus minor unrelated patches (I'm a few commits behind main, but I don't see any way any of them could influence this bug)

[Rangnarok123]

Perhaps what I saw is related to this. I was GM in my game, and other people could see me as the blue Mythran. I turn GM off (level 0) and I became invisible to them (with the message informing me so) I turn to GM again, and I became visible to other people again.

I didn't think this was normal at all. What I had to do was to became GM (which turns me visible), then toggle with /gminvis to become invisible again. Then when I turn off GM, other people would see me (as it should).