DarkflameServer
DarkflameServer copied to clipboard
BUG: Speed Exploit involving spinjitzu interuption
-
[X] I have checked that this issue has not already been reported.
-
[X] I have validated that this issue is not a syntax error of either MySQL or SQLite.
-
[X] I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.
Issue Description
While having a speed boost, if you channel spinjitzu and have it get interrupted it builds a permanent 'stack' of speed. You can stack this further by channeling spinjitzu and getting it interupted again. You can stack this an undetermined amount of times, however it quickly grows. You then use a charge attack and then move very quick until you leave the game or the planet.
Reproduction steps
https://www.youtube.com/watch?v=LH0B0KZNj2Q Use a speedboost channel spinjitzu, don't release get hit out of it repeat x times use wormholer or other charge attack go really fast until leaving
Expected Behavior
You should not be gaining speed after getting your spinjitzu channel cancelled
Environment
Luplo server, client on windows nothing special
Not sure the Reproduction Steps are quite correct here. In my experience:
- I have only been able to do this with the Num-chuks of Lightning.
- I have not needed to apply a speed boost, but can do it by getting hit by the Skeleton Engineers' knockback.
- I haven't needed to use a charged attack, just any melee.
pretty sure this is the same issue as https://github.com/DarkflameUniverse/DarkflameServer/issues/139
Interesting, looks like this happens with the Shurikens of Ice as well, and maybe just involves receiving damage while in Spinjitzu. I wasn't able to replicate it with the Swords of Flames though, oddly enough.
I'm wondering if this should be higher priority, since it's an exploit and pretty easy to perform on nearly any world.
Yeah sorry that it's a duplicate, Avery said that no one had reported it and told me to submit it ASAP so I didn't check.
I've been looking into this and the issue seems to be with interrupting the speed behavior. When interrupted the end never triggers so the speed buff is never removed. This also causes the speed multiplier to be disabled until something else re-enables it. While this could be a special case for just the speed behavior, there could be other behaviors that need to be cleaned up when an interrupt occurs and have just not appeared as major bugs yet.
Fixed in #881, being interrupted will end player skills now