OpenCalc icon indicating copy to clipboard operation
OpenCalc copied to clipboard

Fraction output

Open bmg1919 opened this issue 10 months ago • 4 comments

This may need further testing. All fraction output is mixed if numerator is larger than denominator. I can add an option for improper fractions if desired, maybe even a button to switch the current result from one to the next (mixed/improper, proper, decimal).

bmg1919 avatar Jan 29 '25 16:01 bmg1919

Thanks for your PR, here is some changes to do before merging:

  • [ ] Add an icon to both setting options (the first one is already used by another option)
  • [ ] When you click on then result, it should display the default result (and vice versa)
  • [ ] Should not display the fraction output if there is no calculation
  • [ ] The app crashes when you put a big number like "5555555555555555" (no idea of why)
  • [ ] Perhaps change the output format to an html format like "$num/$deno", because it's very not beautiful right now

clementwzk avatar Apr 13 '25 11:04 clementwzk

any news?

clementwzk avatar May 11 '25 12:05 clementwzk

any news?

Other than icons, I have some changes near ready to push.

bmg1919 avatar May 11 '25 14:05 bmg1919

Thanks for your PR, here is some changes to do before merging:

  • [x] Add an icon to both setting options (the first one is already used by another option)
  • [ ] When you click on then result, it should display the default result (and vice versa)
  • [x] Should not display the fraction output if there is no calculation
  • [x] The app crashes when you put a big number like "5555555555555555" (no idea of why)
  • [x] Perhaps change the output format to an html format like "$num/$deno", because it's very not beautiful right now

I've directly addressed the issues I've marked. I need to find or make some different icons for the menu option. I did reuse the precision icon. Instead of touching the screen to switch results, it currently shows both decimal and fraction results on pressing the equals button.

bmg1919 avatar May 11 '25 17:05 bmg1919

any news? @bmg1919

clementwzk avatar Jul 18 '25 12:07 clementwzk

Probably worth a look now.

bmg1919 avatar Jul 18 '25 19:07 bmg1919

i will check that now, can you solve the conflicts btw ?

clementwzk avatar Sep 21 '25 14:09 clementwzk

image i do not really inderstand why i cannot use this branch. I do no see another one with the same name, it's very weird

clementwzk avatar Sep 21 '25 14:09 clementwzk

Working on it

bmg1919 avatar Sep 21 '25 14:09 bmg1919