OpenCalc
OpenCalc copied to clipboard
Darkempire78
Added Nothing OS themes
The Nothing Phone default calculator doesn't have a theme matching the rest of the design so I created one for OpenCalc in both light and dark.
Community post: https://www.reddit.com/r/NothingTech/s/VV7XRvDExT
There is an APK release on my fork but thought it wouldn't hurt to see if it was something you'd be interested in incorperating in the original version so those who would like the theme can just find OpenCalc through the channels rather than a specific version.
Gradle version update as well as a few code fixes, screenshots and a tweak to the README are also present. :)
That theme(s) adds 1/8 of current size and it isnt one of the default themes
Maybe system for managing of custom themes would be better for the future if there would be more people, who would like to create its own themes - Like structure, import, show, delete
@drrnb That was just example, there is more. Would you keep it up to date, if it was added?
@Darkempire78 why isnt amoled private? Is there reason? Or should I create PR?
@inson1 It wouldn't compile without it, IDE complained 🤷♂️
In regards to the other comments if it's easier I could close this PR and just work on and publish a fork specifically for Nothing users with the default theme being the Nothing themes and cherry pick merges from the original repo for the rest of the app functions.
@drrnb I'm not against adding it :) (also not my call xD) How did you get the icons? Did you create them? Are they online? (that is the part of keep it up to date, if you created them) some things should be added anyway (like changing the fond)
Shouldnt dark and light theme use same system for dark/light theme as it is set now? or it cant be used?
Hi @drrnb, Thanks for your PR, this update will be merge, you do not need to maintain a fork. Can you polish your PR as asked by @inson1. I will check the code and the app size as fast as possible, but I'm very busy at the very moment
@inson1 The icons are using the same TTF font as the rest of the text currently but those that don't currently exist I can create drawables for and tidy up the overall look of the themes although saying that, the Nothing design style is the dot font and a thin monospace style so I may just do the PI icon, infinity symbol etc.. as that and keep the standard buttons and text in the dot font.
@Darkempire78 Thanks, I will work on it within the next week and let you know here when I think it's updated to a better overall polished look. :)
@drrnb There is a conflict with your PR, can you fix that please ? Btw is the theme finished ?
Btw the Light version of the theme looks very weird. Perhpas it needs to be reworked. I found a version of Opencalc modified for Nothing phone (it is violating the licence lmao, I will report it to Google). But the colors look good. What do you think ?
pi and sqrt are not following the theme
I know. I think I need to convert the buttons to ImageButtons like the others to make them look right. Then tackle the actual display of the characters. Ran out of time last night so pushed as far as I'd got.
The issue is the Nothing font I used doesn't contain all characters so I'm having to crudely make drawable versions of the missing ones. Haha
RE: Light mode - Completely agree, was gonna look into colouring after I fixed the icons :)
I mean, can't you like make a simple svg for PI and sqrt. Edit it in fotoshop or something and then export as svg?
is it still in progress?
I've been so busy I haven't had the time, I'd love to continue and update it though when I can find the time, that's just not right now unfortunately. :(