OpenCalc
OpenCalc copied to clipboard
Outdated and inconsistent dialogs in settings
Describe the bug Some of the dialog menus used in the settings are outdated and look out of place. They don't follow the Material You color palette and instead have a Material 2 design.
To Reproduce Steps to reproduce the behavior:
- Go to 'Settings'
- Click on 'Number of decimal places' or 'Results saved in history'
- See the old dialog/fragment
Expected behavior They should be similar to the dialog menu used for the 'Theme'.
Screenshots/videos
Smartphone (please complete the following information):
- Device: Galaxy S20+
- OS: Android 13
- Version: 3.0.0-beta3
- Language: English
Additional context I saw this issue in only 2 of the 3 menus found in the app which are mentioned above.
I made a branch to fix that: https://github.com/Darkempire78/OpenCalc/tree/fix-%23299 It's now using the material design 3, but not with the good colors
I made a branch to fix that: https://github.com/Darkempire78/OpenCalc/tree/fix-%23299
It's now using the material design 3, but not with the good colors
Thanks, it is still a clear improvement.
@Darkempire78 you could also add screenshots. It could save few minutes.
@Darkempire78 you could also add screenshots. You could save as few minutes.
Please be respectful. @Darkempire78 is doing free and volunteer work on an open source project. He literally has zero obligations to you, and if you want luxury treatment you better be donating him a handsome amount before speaking.
@meenbeese I didnt meant that in any disrespectful way. Just pointing it out. It would be nice. Yes, in future I'm going to donate. + I'm going to provide the screenshots. Here they are.
@meenbeese I didnt meant that in any disrespectful way. Just pointing it out. It would be nice. Yes, in future I'm going to donate. + I'm going to provide the screenshots. Here they are.
I'm sorry if I sounded harsh, but I see this attitude in many people who are new to open source. It only demotivates the developer and harms the community. Your original comment sounded very condescending, so thanks for modifying it @inson1.
@meenbeese To be clear I wanted to add the screenshots when I added the first comment. So that could changed the meaning. I didnt change the comment to be nicer, it just souded better. I didnt meant to sound condescending, its just nice when people share also the screenshots. So I want luxury treatmeant for everyone from everyone xD People can forget and that is ok.