OpenCalc icon indicating copy to clipboard operation
OpenCalc copied to clipboard

Results right bound, hence scrolling necessary

Open Aircan opened this issue 3 years ago • 4 comments

Bug: Calculating 1/3 = 3333333333 You have to scroll to the left to see 3.333333... So right binding is useless. And too many digits after comma, too. Talking about portrait mode

Aircan avatar Jul 29 '22 20:07 Aircan

The first part can be solved by changing the parameter of the following line to 0 instead of input.text.length. https://github.com/Darkempire78/OpenCalc/blob/629d86c27ce96ce38629f553e4b066b913cee985/app/src/main/java/com/darkempire78/opencalculator/MainActivity.kt#L425

R-Dson avatar Jul 29 '22 22:07 R-Dson

If a result would overflow, dynamically reduce font, to a minimum base size, else optionally wrap long lines after minimum font size reached, up to a maximum number of lines, then if still overflow, dynamically give a UI indication of more to look at (i.e. translucent down arrow), and allow vertical scrolling. At least for me, this is generally the UI pattern I would expect and most appreciate. Variations on the idea, and incremental improvements welcome.

Leif-W avatar Jul 30 '22 01:07 Leif-W

I mean, we could show "..." to show that it continues and then if one taps. It popups with the whole number.

ghost avatar Aug 20 '22 11:08 ghost

I really think nobody needs more than 7 digits behind comma

Aircan avatar Aug 21 '22 13:08 Aircan

The first part can be solved by changing the parameter of the following line to 0 instead of input.text.length.

https://github.com/Darkempire78/OpenCalc/blob/629d86c27ce96ce38629f553e4b066b913cee985/app/src/main/java/com/darkempire78/opencalculator/MainActivity.kt#L425 @Vanillj

We cannot use that, because it will set the cursor at th first position. We want to scroll to the beginning of the EditText, but keep the cursor at the end of the calculation

I found nothing to do that for the moment...

clementwzk avatar Oct 31 '22 15:10 clementwzk

Fixed 721e83cacd655d58f9624a5849181172d4f61cc4

clementwzk avatar Nov 03 '22 17:11 clementwzk