Darkrift 2.4.1 issues

[LukeStampfli]

The version 2.4.1 (and probably 2.4.0) have some major issues.

I haven't encountered personally but have collected some information from the discord:

They all seem to be related to 2,4,1 and should be reproduce able with the demos or the agar example

[JamJar00]

Thanks for compiling these Allmaron. As a suggestion for fixing them, try suggesting people add the following to their configuration:

<cache
    maxAutoRecyclingArrays="0"
    maxExtraSmallMemoryBlocks="0"
    maxSmallMemoryBlocks="0"
    maxMediumMemoryBlocks="0"
    maxLargeMemoryBlocks="0"
    maxExtraLargeMemoryBlocks="0"
/>

and set the same values to 0 on their clients.

Other useful information would be whether solely having max AutoRecyclingArrays set to 0 works or not, or solely having the max blocks values set works or not.

I'm hoping to have some time tomorrow to look into this and at least fix some of the issues!

[kevinfoley]

We are also getting lots of new crashes with 2.4.1. This is one error I've seen repeatedly:

NullReferenceException: Object reference not set to an instance of an object
DarkRift.MemoryPool.ReturnInstance (System.Byte[] buffer) (at <1382a70d9ec94c9ba407526a5665c33c>:0)
DarkRift.ObjectCache.ReturnMemory (System.Byte[] memory) (at <1382a70d9ec94c9ba407526a5665c33c>:0)
DarkRift.AutoRecyclingArray.DecrementReference () (at <1382a70d9ec94c9ba407526a5665c33c>:0)
DarkRift.Message.Dispose () (at <1382a70d9ec94c9ba407526a5665c33c>:0)
Dissonance.Integrations.DarkRift2.DarkRift2Client.OnEvent (System.Object sender, DarkRift.Client.MessageReceivedEventArgs e) (at Assets/Dissonance/Integrations/DarkRift2/DarkRift2Client.cs:53)
DarkRift.Client.Unity.UnityClient+<>c__DisplayClass57_1.<Client_MessageReceived>b__0 () (at Assets/DarkRift/DarkRift/Plugins/Client/UnityClient.cs:320)
DarkRift.Dispatching.ActionDispatcherTask.Execute (System.Boolean synchronous) (at <1382a70d9ec94c9ba407526a5665c33c>:0)
Rethrow as DispatcherException: An exception occurred whilst running a distaptcher task. See inner exception for more details.
DarkRift.Dispatching.ActionDispatcherTask.Execute (System.Boolean synchronous) (at <1382a70d9ec94c9ba407526a5665c33c>:0)
DarkRift.Dispatching.Dispatcher.ExecuteDispatcherTasks () (at <1382a70d9ec94c9ba407526a5665c33c>:0)
DarkRift.Client.Unity.UnityClient.Update () (at Assets/DarkRift/DarkRift/Plugins/Client/UnityClient.cs:226)

[JamJar00]

Interesting, I've discovered some of the causes and I hope to have a patch out soon for those I know about. If you can provide an example project that causes this though that would be a tremendous help!

[JamJar00]

@kevinfoley your NullReferenceException is probably fixed in DR 2.4.3, let me know if you're still having issues though!

https://www.darkriftnetworking.com/DarkRift2/Releases/Free/2.4.3.unitypackage https://www.darkriftnetworking.com/DarkRift2/Releases/Pro/2.4.3.unitypackage?invoice=