SkyFactory-4
SkyFactory-4 copied to clipboard
Add various recipes to clean up a few weird things
As stated in #1587, Maniacal Dendrologist is impossible due to thorn roses, thorn leaves, and liveroots (the block) being unobtainable. I created a few recipes that I believe solve the issue. I thought this would be nice to have because of how advancement-focused this pack seems to be.
also it just really annoyed me im going for 100% advancements and this one is mocking me by being impossible
Apologies for any incorrect terminology or poor committing practices, I learned how to use Git specifically so I could make this pull request. The actual config files work fine.
Did a lot of cleanup on this. I reorganized things to be consistent with the pre-existing organizational structure of SkyFactory 4 and fixed recipe conflicts with Twilight Forest and Malisis Doors. Specifically, Twilight Forest's unique pressure plates, buttons, and trapdoors now craft instead of the vanilla wooden trapdoor, and Malisis Doors backported trapdoors correctly craft as well.
This was done in what feels to me like a bit of a hacky manner, but it works. I barely know what I'm doing with CraftTweaker but I really wanted to resolve these issues.
Gonna add recipes to make use of Rustic's tiny piles of iron dust when I stop being lazy.
Thank you for this! One small change needed in my opinion, then needs some testing.
@sam-kirby I'm glad it's useful! Sorry about the awkward recipe, I'm still very new to crafttweaker as I stated earlier (and also programming), haha I'll work on it.
Added a few more things as well as changed TF recipe. Tiny Pile of Iron Dust isn't completely useless anymore! I also have a few more ideas for changes that I could make to clean up various things if you'd like to look over them.
-remove creative jetpack components from JEI (they are useless)
-remove osmium ore from JEI and all recipes that use it because osmium ore is unobtainable(?)
-remove all the recipes associated with Mana Infused Ore because it is unobtainable and mana infused stuff is useless anyway (also remove mana dust)
-remove everything related to iridium for the same reason
-remove a bunch of gears that are useless
iridium
constantan
steel
silver
nickel
lead
bronze
tin
copper
platinum
lumium
-remove a bunch of plates that are useless (literally all of them except iron and invar)
-remove washing factory recipes associated with osmium, iridium, aluminum, and mana infused ores (mostly putting this here to remind myself to do it)
-add smeltery stuff for lapis and quartz (think this has already been done in a different pull request)
-add red stained wood and infused wood to the ore dictionary just for fun (make exceptions for their respective conflicting recipes)
-remove TF uncrafting table from JEI
-TF seems to have unique doors but they appear buggy and also aren't required for Manical Dendrologist, maybe remove from JEI? or somehow fix?
-remove ultimate ingot and associations from JEI
-remove crystaltine catalyst from JEI
-remove black iron rod from JEI
-remove anvil smashing recipe for mulch?
-remove forge microblocks/inspirations stone rods from JEI
-remove zephyrean aerotheum and tectonic petrotheum from JEI and melter recipes
-remove primal mana from JEI
-remove all the other unusued thermal foundation liquids
-remove bitumen from JEI
-remove dense and vacuum variants of itemducts from JEI (this looks like it would be frustrating to do unfortunately)
-bunch of matter ovedrive things with bugged textures i cant find a use for, maybe remove from JEI
-remove unobtainable statues mod things
I added processing for Ironberries, but not for the rest of rustic's liquids... that's a bit weird. Gonna change that for consistency.
Y'know, this has really expanded beyond the original scope of fixing one single advancement! I might go ahead and hide all those gears and things that are useless later.
If someone doesn't like these changes, I'll revert them back to just the recipe conflict fixes. sam-kirby commented after I mentioned plans to change more things, so I assumed they were ok with these changes. If not, I'll revert them.
This is done being updated by the way. I tested it and everything seems to work. Let me know if I should make any more changes.
I heard something about issues being pulled after 30 days by default if there's no activity. I'm not sure if it applies to pull requests too, but I'm going to bump this every once in a while to make sure. I'm not sure if this is still something people want to merge.
23 day bump. If there are any issues you guys have with this pull request, please let me know and I'll work on fixing them.
I don't understand the reasoning for enabling ale wort, or why that justifies adding another new fluid?
I don't understand the reasoning for enabling ale wort, or why that justifies adding another new fluid?
Ale Wort is already enabled and craftable, it's just not clear how to make it, and it's disabled in JEI for some reason. The new fluid I added is literally just because I thought it would be nice for all the Rustic stuff to work with all the machines. This happened as a result of my trying to make tiny piles of iron dust useful, which created inconsistencies as to how Rustic items are processed, so I ended up making them all processable through machines.
I can just remove all this if wanted. This PR went beyond just fixing TF inconsistencies into fixing general SF4 inconsistencies, and I admit I overstepped what I was originally supposed to be doing. I assumed that seeing what appeared to be encouragement after I said I planned on doing more things was a sort of "green light" to keep going.
Thanks for this; in the future it would be best if you open separate, targeted PRs - associated with issues if possible. Everything you've done was worthwhile, it just makes it a bit harder to follow the logic when there are multiple unrelated changes in one PR.
You can have multiple PRs open at once by creating branches on your fork of the repo and then creating PRs from each branch.
I'm minded to merge this as is, please let me know if you have any comments.
Thanks for this; in the future it would be best if you open separate, targeted PRs - associated with issues if possible. Everything you've done was worthwhile, it just makes it a bit harder to follow the logic when there are multiple unrelated changes in one PR.
You can have multiple PRs open at once by creating branches on your fork of the repo and then creating PRs from each branch.
I'm minded to merge this as is, please let me know if you have any comments.
Yeah, that would make sense. I'll do that if I end up making any more changes. Apologies for not really knowing what I'm doing, but I'm glad I was helpful in the end.