AdvancedChatHUD
AdvancedChatHUD copied to clipboard
[BUG] Incompatibility with Labymod due to a misuse of Mixin
Describe the bug The bug causes Minecraft with Labymod to crash on Server Join
Minecraft Info Minecraft information:
- advancedchatcore 1.19.4-1.5.10
- advancedchatfilters 1.19.4-1.2.8
- advancedchathud 1.19.4-1.3.8
- Labymod 4.0 with Fabric Mod Loader installed via Addon Store
To Reproduce Steps to reproduce the behavior:
- Start Minecraft
- Join Server
Expected behavior It should be possible to join the Server, without a crash.
Additional context Tested on Hyperknox.world as well as on our building Server. But this shouldn't matter. The crash is only happening when using Labymod 4 together with AdvancedchatHUD. I've talked to a Labymod Developer regarding this issue on Discord. The issue seems to be a that the mod misuses a feature of Mixin. This misuse works in the environment Fabric uses, but not in Labymod environment.
Information from Labymod The issue is here: https://github.com/DarkKronicle/AdvancedChatHUD/blob/68f2b97f975ac605191252c7b67d22d681bd0a07/src/main/java/io/github/darkkronicle/advancedchathud/mixin/MixinChatHud.java#L160 The shadow method (so the Minecraft method) has the same name as one of the methods of the interface that is implemented. Mixin has the Implements and Intrinsic annotations to fix this. The shadow method should be prefixed with shadow$ and then called by another method marked with Intrinsic and prefixed with the prefix previously configured with the Implements annotation.
Log https://mclo.gs/O5A1XUV