Darin
Darin
@taojieterry I'll take a look to make sure but you're likely correct.
@taojieterry Will checkout this week. Do you think it's at the point you'd like it to be merged?
@taojieterry sorry got caught up in a new job. Will try to find some time this week.
Looks good but haven't tested, if you're comfortable then merge away!
I can do some tests early to mid next week, unfortunately I'm swamped tomorrow.
@yufeldman Nope - I'm behind on some other items so haven't been able to test yet. Hopefully will get to it tonight/tomorrow.
Tested a bit, seemed OK, had to add user:password@ to the URI's for binary dist and config if using myriad to distribute.
Is this a good idea? Seems like we're adding more config to Myriad maybe we should just throw a runtime exception?
8088 is yarns default HTTP port and 8090 is the HTTPS port. If neither are in the yarn-site.xml they'll revert to those. The original check in code was for sanity...