Naqua Darazaki comments

Results 17 comments of


                                            Naqua Darazaki

Adding the ability to select multiple words at a time

Okay! I think I've finished nitpicking :) As I said, you don't need to implement all of that if you don't feel like it. I'm not your boss or anything....

Adding the ability to select multiple words at a time

What I meant is that whatever whitespace gets in between what would have been considered 2 words by the original `SpedreadWindow.next_word` implementation should be converted into a space. Sorry if...

Adding the ability to select multiple words at a time

I think I finally understand why you wanted to remove appdata from the translations, translations should be updated through `dev-scripts/update-translations.sh` rather than manually (I assume that's what caused all the...

Adding the ability to select multiple words at a time

> The reason I made words_at_a_time static is because next_word function is static, and it needs this attributes, however next_word also compiles and seems to work if I make it...

Adding the ability to select multiple words at a time

> It keeps saying invalid multiple byte sequences and it wants me to use ASCII That's... even weirder? ASCII actually seems to be the default according to `man xgettext` so...

Adding the ability to select multiple words at a time

> As a workaround, what I found to be effective was to add the non translatable strings to the _excluded.po file. Now it updated the correct translations. That sucks, I'll...

Adding the ability to select multiple words at a time

> I have nothing else for this PR Perfect thanks! I'll publish all of that in v2.6.0 of Spedread :) I have a few extra things I'd like to do...