DapperMickie

Results 27 comments of DapperMickie

> This should probably be changed to consume a filter of author and search, I think. It would eliminate a lot of the conditional logic you added. What would that...

You've added 2 plugin files "harry-potter-spells" and "/plugins/Harry Potter Spells". There should only be 1 file added and it should be in the "plugins" directory. Delete the "harry-potter-spells" file you've...

You also might want to change this: https://github.com/JonasDJ1999/Harry-Potter-Spells/blob/Harry-Potter-Spells/build.gradle#L26 to "com.harrypotterspells".

> > You've added 2 plugin files "harry-potter-spells" and "/plugins/Harry Potter Spells". There should only be 1 file added and it should be in the "plugins" directory. > > Delete...

Here is a link to the file that should be deleted: https://github.com/JonasDJ1999/plugin-hub/blob/master/harry-potter-spells

> > Here is a link to the file that should be deleted: https://github.com/JonasDJ1999/plugin-hub/blob/master/harry-potter-spells > > okay I deleted that and renamed the other, what now? Commit the changes :)

Cool idea to let it find the fastest path, but I think it would be much more reliable if there were established paths to take (that can then be optimized...