Dapper
Dapper copied to clipboard
Possible bug: `GridReader` constructor uses `DynamicParameters` cast instead of `IParameterCallbacks`
In the GridReader constructor, the parameter type is IParameterCallbacks? callbacks.
But when creating a GridReader, the code does:
command.Parameters as DynamicParameters instead of: command.Parameters as IParameterCallbacks
This makes custom implementations of IParameterCallbacks unusable, even though the constructor was designed to support them.
Should this be changed to use IParameterCallbacks instead of DynamicParameters?
Possibly. If it works with the interface, then I can't think of a reason not to prefer it.
Sounds like a possible bug, yes