Dapper icon indicating copy to clipboard operation
Dapper copied to clipboard

Possible bug: `GridReader` constructor uses `DynamicParameters` cast instead of `IParameterCallbacks`

Open zzjbook opened this issue 4 months ago • 1 comments

In the GridReader constructor, the parameter type is IParameterCallbacks? callbacks.
But when creating a GridReader, the code does: command.Parameters as DynamicParameters instead of: command.Parameters as IParameterCallbacks This makes custom implementations of IParameterCallbacks unusable, even though the constructor was designed to support them. Should this be changed to use IParameterCallbacks instead of DynamicParameters?

zzjbook avatar Aug 22 '25 01:08 zzjbook

Possibly. If it works with the interface, then I can't think of a reason not to prefer it.

Sounds like a possible bug, yes

mgravell avatar Aug 22 '25 19:08 mgravell