geocoder icon indicating copy to clipboard operation
geocoder copied to clipboard

Geocoder.Providers.Fake returns {:error, nil} when nothing is found on call_list/1

Open pierrelegall opened this issue 1 year ago • 1 comments

Current behaviour

Geocoder.Providers.Fake returns {:error, nil} when nothing is found on call_list/1.

Expected behaviour

Geocoder.Providers.Fake should returns {:ok, []} when nothing is found on call_list/1.

pierrelegall avatar May 28 '24 20:05 pierrelegall

Interesting, happy to accept a PR here!

CyrusNuevoDia avatar May 29 '24 20:05 CyrusNuevoDia

I will take a look at this this week.

epinault avatar Dec 13 '24 23:12 epinault

Done!

CyrusNuevoDia avatar Dec 16 '24 23:12 CyrusNuevoDia

@CyrusNuevoDia what MR fixes it?

epinault avatar Dec 17 '24 00:12 epinault

@epinault i pushed to main

CyrusNuevoDia avatar Dec 17 '24 00:12 CyrusNuevoDia

I see. You got the wrong version released. Does not match the bump I had done my changelog and my MR for you to just run

epinault avatar Dec 17 '24 00:12 epinault