DannyDaemonic

Results 65 comments of DannyDaemonic

[ggerganov addressed this](https://github.com/ggerganov/llama.cpp/pull/1297#issuecomment-1533314364) in the PR, suggesting it's not as trivial as it sounds. Maybe it would require restructuring too much of the main loop/flow. *I think* I might be...

@slaren > but how do we find what version they are using from this information? To go the other direction: ```bash git rev-list HEAD --skip=$(( $(git rev-list HEAD --count) -...

@j-f1: The date might be better for a quick judge of how old something is. I thought a straight number component would be more useful in the long run because...

I committed a change so it shows the hash and the build number. I think this is better after all. ``` main: build = 464 (5e7d90a838c2543687fcff2e603b1189b6bc1084) main: seed = 1682785118...

@Green-Sky Oh I see what you're saying. If someone else is using this project in their own project, cmake should be smart about that since it would still be a...

Alright, I put `CMAKE_CURRENT_SOURCE_DIR` back and checked for any other spots it may have caused issues when used with `add_subdirectory()`. I also made the building comments a little more descript.

@sw Yeah, it's embarrassingly easy to fix. Everything else is all set up to generate dummy values. I just overlooked that dependency line because I originally wasn't going to add...

@sw > I think you have to use find_package(Git) in the top-level CMakeLists.txt as well, not just in the generated BUILD_INFO.cmake. Hmm, I don't know why that would make a...

@slaren Oh, Yeah, I could do that much without reshaping the makefile. Previously, I was thinking of something like this: ```Makefile # Define the targets TARGETS := main quantize quantize-stats...

@ggerganov: Oh, good catch. @slaren I tried to make that particular pattern/rule work but it was really not having it. The only way to join the target with a variable...