hash-wasm icon indicating copy to clipboard operation
hash-wasm copied to clipboard

Consider adding WASMInterface to the list of exports in lib/index.ts so I can reference IHasher from client code

Open alasdaircs opened this issue 1 year ago • 1 comments

I want to declare a variable of type IHasher in my TypeScript code, but it's declared in WASMInterface.ts and although that builds to /dist/lib/WASMInterface.d.ts, it's not exported in /lib/index.ts so I can't write:

import { IHasher } from 'hash-wasm';

If I attempt to reference it directly with import { IHasher } from 'hash-wasm/dist/lib/WASMInterface' I get compiler errors from my WebPack build.

Please consider adding:

export * from './WASMInterface';

to lib/index.ts

alasdaircs avatar Jun 17 '24 14:06 alasdaircs

On reflection I've just found I was importing from the wrong place 🤦‍♂️: This doesn't work: import { IHasher } from 'hash-wasm/lib/WASMInterface', probably because I'm stuck on an old version of TS But this does work: import { IHasher } from 'hash-wasm/dist/lib/WASMInterface'

There's no urgency, but I still think it would be nice to be able to write:

import { IHasher } from 'hash-wasm'

alasdaircs avatar Jun 17 '24 14:06 alasdaircs

You can instead use Awaited<ReturnType<typeof create***>> to capture the type of IHasher.

GabenGar avatar Oct 25 '24 18:10 GabenGar

I added the export to the new v4.12 version

Daninet avatar Nov 19 '24 19:11 Daninet