matrix-highlight icon indicating copy to clipboard operation
matrix-highlight copied to clipboard

Make highlight-messages visible in a normal matrix client

Open Stvad opened this issue 2 years ago • 4 comments

It'd be great if one could see the messages in the normal Matrix client and continue the discussion there!

people in #matrix-highlight:matrix.danilafe.com mentioned that you had some plans to do it @DanilaFe !


I've actually built a quick prototype of this in my fork 🙃

image image


Architecture-wise I think the "correct" approach would be to rely on extensible events, but I failed to make those actually display in Element. (and they are still in the state of MSC with unclear acceptance date)

So for now prototype shoves everything into content of m.room.message - that worked! :)

Stvad avatar Jan 01 '23 01:01 Stvad

lmk if you'd be ok with accepting a PR with that prototype architecture!

Stvad avatar Jan 01 '23 01:01 Stvad

I would still be interested in this as a PR, particularly if you just modified the existing events sent by matrix highlight to include additional information.

DanilaFe avatar Apr 20 '23 22:04 DanilaFe

You can't do that, until Extensible Events is a thing. To be displayed in the normal matrix client, we currently need to pretend to be m.room.message with some custom fields on the side.

In my version this works well, the structure of the data remains the same, and I preserved the backwards compatibility with the old event type

Stvad avatar Apr 22 '23 02:04 Stvad

I find it quite upsetting that extensible events, unlike other MSCs, do not have an Element implementation. My current plan is to allow matrix highlight to handle message events, and put how it sends highlights behind a setting (toggle between custom event type and m.message)

DanilaFe avatar Apr 22 '23 17:04 DanilaFe