matrix-highlight icon indicating copy to clipboard operation
matrix-highlight copied to clipboard

Ignore http/https and anchor differences in URLs

Open DanilaFe opened this issue 3 years ago • 5 comments

Otherwise, sending someone a link to a sub-section of a page can make them unable to see the highlights.

DanilaFe avatar Jan 15 '22 21:01 DanilaFe

Is there anything that needs to be done to account for sites that use hash-routing?

gleachkr avatar Jan 15 '22 21:01 gleachkr

I was wondering the same thing. Even something like matrix.to for instance. I am not sure how to reconcile the two approaches, to be honest.

DanilaFe avatar Jan 15 '22 22:01 DanilaFe

The only thing I can think of is to make it user-configurable, probably with an "ignore anchor differences" default - maybe storing whether this site uses hash-routing in room-state somehow?

gleachkr avatar Jan 17 '22 17:01 gleachkr

That sounds like a good way of doing it - I wonder where this would be stored, though. Account data? Some kind of matrix highlight space or room? Seems like the latter approach is cleaner.

DanilaFe avatar Jan 19 '22 16:01 DanilaFe

It does seem like this data should be shared between clients, so yeah, I'd say in the state of whatever matrix-entity is representing the annotation target.

gleachkr avatar Jan 19 '22 18:01 gleachkr