Danil0v3s
[Fix] require hotkey to be pressed once
- Fixed the issue triggering the overlay and recording shortut only on second press
- The Hotkey now requires both ctrl and alt to be pressed. Previously it was possible to open the overlay just by ctrl + f10
Hey, thanks for the PR!
It looks alright and I'll merge it, but I wanted to ask first how first how familiar do you feel with c#. This library actually borks debug, once you set a breakpoint with the library enabled the pc just dies.. that's the reason I only enabled it when dev=false.
I was thinking about implementing it directly on the native side and communicate via pipes/socket
Hey!
I have only little experience with C# particularly in Unity. I come from a web developer background and some experience in Android Development with Jetpack Compose. I found out that this project uses KMP and I wanted to get my hands dirty on that for the first time.
I did notice degraded performance when trying to debug with breakpoints to narrow down this overlay issue. Good to know that this might be the implementation of the library!
I didn't look on this site of things. But if I understand correctly, you've implemented the hardware monitor in kotlin and want to rewrite this in c#?
Hey, thanks for the PR! It looks alright and I'll merge it, but I wanted to ask first how first how familiar do you feel with c#. This library actually borks debug, once you set a breakpoint with the library enabled the pc just dies.. that's the reason I only enabled it when dev=false. I was thinking about implementing it directly on the native side and communicate via pipes/socket
Hey!
I have only little experience with C# particularly in Unity. I come from a web developer background and some experience in Android Development with Jetpack Compose. I found out that this project uses KMP and I wanted to get my hands dirty on that for the first time.
I did notice degraded performance when trying to debug with breakpoints to narrow down this overlay issue. Good to know that this might be the implementation of the library!
I didn't look on this site of things. But if I understand correctly, you've implemented the hardware monitor in kotlin and want to rewrite this in c#?
No, not at all! The monitor itself is written in C# and uses LibreHardwareMonitor as a replacement for third party software. Initially I was using sockets to IPC but sockets require network usage consent so I swapped to pipes. The reason I ask is because maybe we could use the same IPC strategy for the monitoring to implement the hotkey.
But since you said you're not familiar with C# we can fix this issue and then I try to implement it on the C# side when I have some time
Hey so the solution was to make the flow a hot flow https://github.com/Danil0v3s/CleanMeter/commit/b719f4a894fc92a5535e2e47ba3b3b617dc36002