Daniel Mizerski
Daniel Mizerski
Rebased I wanted to add extending schema feature (growing template), but typescript says it is too sus and prevents taking "base" template as typings for "base" definition.
> This looks useful to me. What tasks are remaining to be ready? @kt3k Ready for review ^^
@kt3k I like those utils done by @dsherret, do we want to add them as dependency and reexport or should we include their copy to std after asking the author...
> @Duelsik We should include the copy of them with copyright attribution in the file header (In principle, std shouldn't depend on any external deps. ref: https://github.com/denoland/deno_std#deno-standard-modules). Copying is ok...
// copy from #31 Hmm... I did that in https://github.com/ryo-ma/deno-websocket/pull/34 but I was only modifying "on" and "emit" since I rarely use other API parts. I think I can add...
Waiting for update in std library, hopefully they will approve my changes :) https://github.com/denoland/deno_std/pull/2111
Hmm... I did that in https://github.com/ryo-ma/deno-websocket/pull/34 but I was only modifying "on" and "emit" since I rarely use other API parts. I think I can add more typings :eyes:
@ryo-ma can you mark it as duplicate of https://github.com/ryo-ma/deno-websocket/issues/30 please?
Feel free to continue this topic, I don't remember why it got stale. @lino-levan
Seen already, a bit shame that it is not separate PR, but we can live with it :)