twitter4s icon indicating copy to clipboard operation
twitter4s copied to clipboard

Handle stream errors - change proposal

Open papirosko opened this issue 5 years ago • 2 comments

This is not an error handling:

  def filterStatuses(follow: Seq[Long] = Seq.empty,
   ...
         errorHandler: PartialFunction[Throwable, Unit] = ErrorHandler.ignore
   ...


object ErrorHandler {
  def ignore: PartialFunction[Throwable, Unit] = {
    case scala.util.control.NonFatal(e) => ()
  }
}

make it at least:

object ErrorHandler {
  val log: Logger = ... 
  def ignore: PartialFunction[Throwable, Unit] = {
    case scala.util.control.NonFatal(e) => log.warn("Error", e)
  }
}

papirosko avatar Aug 09 '19 17:08 papirosko

Hi @papirosko, thanks for the suggestion! Yes, I like your proposal: could you send us a PR?

Thanks, Daniela

DanielaSfregola avatar Aug 09 '19 18:08 DanielaSfregola

https://github.com/DanielaSfregola/twitter4s/pull/245

papirosko avatar Aug 09 '19 18:08 papirosko