rhubarb-lip-sync icon indicating copy to clipboard operation
rhubarb-lip-sync copied to clipboard

Not an issue, except for me: I can't tell if --threads 1is better or not

Open j2l opened this issue 6 months ago • 4 comments

Using linux, I tried with the provided riddle.wav and here are the results. I can't tell which one is better: https://github.com/user-attachments/assets/2aaa027a-0205-4a69-9d50-a574724b2bbb

Any idea?

j2l avatar Jun 21 '25 09:06 j2l

I'm not sure what you're asking. The --threads option has no effect whatsoever on animation quality. It's only meant for special situations, such as running 10 jobs simultaneously. If the results don't match exactly, that's just a result of underlying optimizations.

Don't touch this unless you have to!

DanielSWolf avatar Jun 21 '25 16:06 DanielSWolf

Thank you @DanielSWolf for this great project!

Maybe I didn't get it, sorry. I read a reply you gave to someone else about linux and --threads where the model was learning from previous lines, instead of cutting the audio to various threads, so I wanted to see if there was any difference between normal multi-CPU and when everything is bounded to one CPU. Since I'll have many files to process, I could go one by one, or open multiple terminal windows and use --threads 1 on each (and monitor to leave some space for gnome to breathe).

I don't get which underlying optimizations are involved, if you can explain.

j2l avatar Jun 21 '25 18:06 j2l

In rare situations, the quality may indeed be better with --threads 1, because disabling multithreading means that everything is processed sequentially. In practice, this shouldn't make a difference.

And yes, if you're planning on processing many files, it may be more efficient to keep processing several at once without multithreading instead of processing them one after the other, each with multithreading. That being said, unless you have multiple hours of dialog, processing one after the other (which is easily scriptable) would be my preferred approach.

DanielSWolf avatar Jun 21 '25 19:06 DanielSWolf

Ok, thank you.

j2l avatar Jun 22 '25 18:06 j2l