Daniel Ruf

Results 910 comments of Daniel Ruf

Sorry, forgot that. Seems to be quite easy. You just have to filter it and process the 5th parameter ((array)attachments) with the encryption function. > $attachments should be an array....

Sorry, forget the link, I pasted the wrong link here. You should use the filter_hook, but I am not sure how to replace this. Seems you would have to copy...

Hm, what if we create a temporary file with the encrypted attachment using file_get_contents and the openpgp-php functions, using this instead of the original one and unlinking this temporary file...

For example tmpfile(), php://memory and php://temp

> * php://memory Is a good idea. I've done two small experiments in the past with a few small benchmarks. https://github.com/DanielRuf/inmemory-benchmarks

Sounds like a keyserver implementation. One (additional) solution would be to query pgp.mit.edu or other keyservers. Generally it is better to map email addresses to key IDs, the actual keys...

That sounds good. I'm not sure if renaming fields makes sense. Normally I'm accustomed to having two versions shown in the CVE databases (if provided). I didn't check SecObserve in...

Seems to stop because of the missing logic from these lines: https://github.com/oss-review-toolkit/ort-ci-github-action/blob/15297c37f35256c0e3a977c30771761ff51235d7/action.yml#L417 https://github.com/oss-review-toolkit/ort-ci-github-action/blob/15297c37f35256c0e3a977c30771761ff51235d7/action.yml#L422 https://github.com/oss-review-toolkit/ort-ci-github-action/blob/15297c37f35256c0e3a977c30771761ff51235d7/action.yml#L477 https://github.com/oss-review-toolkit/ort-ci-github-action/blob/15297c37f35256c0e3a977c30771761ff51235d7/action.yml#L482

This is a must have. It seems by default the image quality is lower than the quality of images generated by f:image/media which is not good. (Re)processing should not manipulate...

Well, even in fullscreen there is some quality loss.