Daniel Ruf

Results 910 comments of Daniel Ruf

@hnk15 can you provide these changes as patch file?

A patch file is a file use by patch tools to change files base on a diff. See https://patch-diff.githubusercontent.com/raw/smalot/pdfparser/pull/224.patch

Awesome. Can you provide a PR for this at https://github.com/DanielRuf/html-minifier-terser? That would be really great.

Also I think it makes sense to add some test for this. Can you give this a try or do you need help with this?

> @kangax @DanielRuf might be worth joining forces in one repo. Sounds definitely good. But personally I have minimized the time that I invest in opensource and I have onboarded...

> Yeah, this shouldn't land as is. `innerHTML` is meaningless when we only need to change the text. You are right, `innerText` should be sufficient then.

Stumbled on this by doing a search in my preferred search engine. Would be very great to have this linked in the documentation or directly documented there. Unfortunately the current...

We are getting the following error, when we try to open the admin area: `Uncaught CKEditorError: ckeditor-duplicated-modules` New line in package.json: `"@ckeditor/ckeditor5-font": "^38.1.1",` Code in app.js: ```js // Add project...

Ok, seems to work with `"@ckeditor/ckeditor5-font": "^34.2.0",`. I still think the table and the example should be part of the documentation @alexander-schranz.