zipkin-javascript-opentracing icon indicating copy to clipboard operation
zipkin-javascript-opentracing copied to clipboard

Published 20 hours ago • verified publisher icon DanielMSchmidt

use inheritance from `OpenTracing` base classes

Open Kosta-Github opened this issue 7 years ago • 5 comments

Use proper inheritance from the OpenTracing base classes for Span and Tracer as indicated here: https://github.com/opentracing/opentracing-javascript#opentracing-tracer-implementations

The major change is the usage of TraceId as a span context which is returned from Tracer.extract() instead of a span. The unit tests have been adjusted accordingly. And the implementation have been simplified by this.

Since I don't know much about the zipkin protocol itself, I was not able to fill in some reasonable implementations for the baggage feature of OpenTracing.

Kosta-Github avatar Oct 15 '18 07:10 Kosta-Github

Coverage Status

Coverage remained the same at 100.0% when pulling b2d708ef1e45f74b2a335804f5c01ee25dac3b01 on Kosta-Github:opentracing-inheritance into ee2b64e2dbec1abf1db76d5ab622820af0ac17e7 on DanielMSchmidt:master.

coveralls avatar Oct 15 '18 07:10 coveralls

Hey @Kosta-Github, thank you for your help! I will take a look if I can close the knowledge gap with the baggage part, but it would be ok to me if we would just document them down as currently unsupported to keep the scope smaller.

As this PR is pretty long it might take some time and iterations for me to get completely through it, I hope you understand.

DanielMSchmidt avatar Oct 15 '18 07:10 DanielMSchmidt

I'll give this baby a test ride this weekend and ping you back the results 👍 Thank you for putting in so much effort :)

DanielMSchmidt avatar Oct 18 '18 14:10 DanielMSchmidt

any updated in this?

Kosta-Github avatar Jan 02 '19 13:01 Kosta-Github

Any updates?

Kosta-Github avatar Apr 25 '19 19:04 Kosta-Github