zipkin-javascript-opentracing icon indicating copy to clipboard operation
zipkin-javascript-opentracing copied to clipboard
verified publisher icon DanielMSchmidt

Convert non-string type to string before calling tracer.recordBinary

Open vigneshnrfs opened this issue 7 years ago • 8 comments

vigneshnrfs avatar Mar 29 '18 03:03 vigneshnrfs

Coverage Status

Coverage remained the same at 100.0% when pulling ebfdb1b95b8239f5ad65d113269280a570f78efd on vigneshnrfs:master into ee2b64e2dbec1abf1db76d5ab622820af0ac17e7 on DanielMSchmidt:master.

coveralls avatar Mar 29 '18 03:03 coveralls

Hey @vigneshnrfs Thank you for your help! CI seems to be red, partially on the integration tests, I will try to fix this soon (#37). If it is ok for you I would like to wait until I can do this, if not I will try to verify it and merge it

DanielMSchmidt avatar Mar 29 '18 07:03 DanielMSchmidt

Hi @DanielMSchmidt Let's fix #37 and then do this merge. This can wait.

vigneshnrfs avatar Mar 30 '18 04:03 vigneshnrfs

This PR also addresses #5

vigneshnrfs avatar Apr 01 '18 04:04 vigneshnrfs

Could you rebase this branch? I got at least one of the errors in CI fixed, the other one should also be good now

DanielMSchmidt avatar Apr 12 '18 08:04 DanielMSchmidt

@DanielMSchmidt It's done. I see just one more failing.

vigneshnrfs avatar Apr 12 '18 08:04 vigneshnrfs

table flip

I will give it a second try, I think it is green on master because there is no change to push for the website

DanielMSchmidt avatar Apr 12 '18 09:04 DanielMSchmidt

@DanielMSchmidt Can we fix the travis-ci issue and merge this?

vigneshnrfs avatar Aug 01 '18 03:08 vigneshnrfs