DanielLockau-MLPA
DanielLockau-MLPA
> Would it make sense to rename the existing `rtc_set_time()`, and do the sysbus stuff once, calling the renamed ones? I also thought about having a single place for the...
@maribu Your suggestion would mean that the notifications are still part of periph_rtc but not in the form of hard-wired system bus events. Instead rather in the form of two...
I finally got back to this and addressed existing comments. Not sure whether this proposal will fit coding conventions though. - @kaspar030 I reduced code impact by wrapping rtc_set_time into...
> I think this needs an update. At the time of opening this PR, it seemed sensible to add this feature to RIOT but the number of use cases for...
@benpicco Where should I properly document this added behavior?
> Other I2C peripherals can detect a locked bus or at least have a timeout, that allows to unblock a blocked bus when it happens. @maribu Just to verify that...
I will rewrite this PR and include the unblocking into the driver in the sam0_common driver. As @benpicco indicates, the buserror interrupt/flag is present but currently not used.
@maribu @dylad @benpicco I brought the unlock mechanism to `cpu/sam0_common/periph/i2c.c` and attempt a recovery just before initializing the peripheral or on an error in `_i2c_start`. Touching the i2c driver I...
@benpicco I did squash. @maribu Is your latest comment meant to block? I understood that you want to hook up a test scenario for independently verifying this PR.
> Huh did we forget about this one? I just fixed the documentation error blocking the pipeline and rebased. Hence the force push.