Daniel Hreben

Results 31 comments of Daniel Hreben

@ignacioblit seems like the problem is fixed, can you please confirm and close this PR if so?

@ignacioblit got it. I don't mind to have this code in the library, my main concern is missing tests. So if you can add tests covering all cases this code...

Ugh oh. Nice catch. We definitely need to add a performance test in order to prevent situations like that. Do you have some test to share?

Yes, you are totally right. That's one of the reasons why upsert\insertOrUpdate defined as EXPERIMENTAL in the documentation. Not sure if I will find a good way to fix all...

No, this solution is not ok for 2 reasons: - it's Postgres specific - it executes nested select - may be very problematic for some tricky cases with transactions and...

Hi! I think this is valid use case, not yet supported. You could workaround it like this: ```javascript const Redis = require('ioredis') const redis = new Redis() const RedisAdaptor =...

@dowtkdan no blockers, but it may be not that easy to implement. TTL is specific to adaptors, and currently this value passed directly to their constructors. If we want making...

@usb248 Could you please submit PR with test case covering this issue?