Daniel Heath
Daniel Heath
Anything else still to do on this?
Hi @brendon no worries. Hope you had a great break :)
RE 'there's clearly code intended to insert new records at the right position': Prior to my changes,`insert_at_position` checks `new_record?` and calls `set_list_position` (which saves the record) if it's true. The...
> I think we also need more tests for this one just to be sure it's working in all cases. Were there particular cases / classes of cases you were...
What do you think of these tests?
@swanandp sorry for the radio silence, I've been unwell. Will take a look at the failing tests today.
OK, sorted out the tests and also incidentally fixed the issue where you'd get 'gaps' and duplicate values under concurrency (for postgres & mysql, at least)
@swanandp @brendon anything still needed on this one?
Thanks @swanandp :)
@brendon @swanandp is there anything still blocking this?